Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake, C++ and some interface stuff #15

Open
conradhuebler opened this issue Jan 16, 2023 · 1 comment · May be fixed by #16
Open

CMake, C++ and some interface stuff #15

conradhuebler opened this issue Jan 16, 2023 · 1 comment · May be fixed by #16

Comments

@conradhuebler
Copy link

Hey guys,

I made some changes in a fork, which might be interesting.

First, I was always unable to compile cpp-d4 on my manajaro system (gcc 12) due to the way cblas was included. This change made it compileable.
https://github.com/conradhuebler/cpp-d4/blob/main/include/dftd_cblas.h#L22
Since mixing C and C++ always confuses me, I don't know how to make it work without this adaption.

Second, I added the CMake build system, hence this project can easily be integrated into other cmake project.

Third, I added some functions to manipulate TMolecule, so no xyz file has to be read.

https://github.com/conradhuebler/cpp-d4/blob/main/include/dftd_geometry.h#L46

I somehow hestitate to just make pull request, but who knows.

Cheers,
Conrad
@marvinfriede
Copy link
Member

Hey Conrad!

First, I was always unable to compile cpp-d4 on my manajaro system (gcc 12) due to the way cblas was included. This change made it compileable.

I encountered the same problem when creating a CI workflow and removed this part (9ce9338).

Second, I added the CMake build system, hence this project can easily be integrated into other cmake project.

Third, I added some functions to manipulate TMolecule, so no xyz file has to be read.

Thanks, I think both of these changes can readily be included.

Best,
Marvin

@marvinfriede marvinfriede linked a pull request Jan 18, 2023 that will close this issue
CMake and some interface stuff #16
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake and some interface stuff conradhuebler/cpp-d4
2 participants
@conradhuebler @marvinfriede