Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to fypp v3.2 #79

Merged
merged 1 commit into from
May 3, 2024
Merged

Upgrade to fypp v3.2 #79

merged 1 commit into from
May 3, 2024

Conversation

vanderhe
Copy link
Member

No description provided.

bhourahine
bhourahine approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but probably we should do something better than copying all of fypp every time it updates.

@vanderhe
Copy link
Member Author

vanderhe commented May 3, 2024

Seems fine, but probably we should do something better than copying all of fypp every time it updates.

I think we discussed it once for DFTB+, concluding that it is not worth to set up yet another submodule.

@vanderhe vanderhe merged commit 6996148 into dftbplus:main May 3, 2024
2 of 3 checks passed
@vanderhe vanderhe deleted the fypp-3.2 branch May 3, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhourahine bhourahine bhourahine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanderhe @bhourahine