You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem appears when I manually set the path to the config file.
This means skprogs first reads the default skdef.hsd file and then reads another, let's say, my_skdef.hsd file.
The next step is an update of Skdef dictionary by another dictionary made from my_skdef.hsd.
However, during this update, only the atomparamters field is updating, but not OnecenterParameters and not TwocenterParameters.
All of the written above can be easily fixed below this line
If that was made on purpose, please, let me know why that was made in a such way.
The text was updated successfully, but these errors were encountered:
samtsevich
changed the title
Update skdef dictionary does not update OnecenterParameters and TwocenterParameters fields
An update of skdef dictionary does not update OnecenterParameters and TwocenterParameters fields
Nov 1, 2023
you are right, the fact that ./skdef.hsd is always parsed is counterintuitive. Additionally, as you correctly pointed out, the update mechanism in the backend is broken and has probably never been finalized due to difficulties in the implementation process. I created PR #70 that lifts the restriction of requiring ./skdef.hsd to be present regardless of the user input and further disables the feature of reading in multiple configuration files, at least as long as the backend has not caught up.
The motivation of having the freedom to parse multiple config files in the first place is rooted in the possible parametrization task of extending an existing set like mio-1-1 by e.g. titanium as for the tiorg mio-extension. In that case it could be handy to provide mio-related information in a separate file that is left untouched in the parametrization process.
Describe the bug
The problem appears when I manually set the path to the config file.
This means
skprogs
first reads the defaultskdef.hsd
file and then reads another, let's say,my_skdef.hsd
file.The next step is an update of
Skdef
dictionary by another dictionary made frommy_skdef.hsd
.However, during this update, only the
atomparamters
field is updating, but notOnecenterParameters
and notTwocenterParameters
.All of the written above can be easily fixed below this line
If that was made on purpose, please, let me know why that was made in a such way.
The text was updated successfully, but these errors were encountered: