You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the interface for CallableModel supposed to support parameter values? It doesn't appear that this is currently possible (it would need to be sub-classed for the user to define parameter_names (which is used to determine full_size), but then it doesn't propagate any kwargs back to Model.__init__ for specifying parameter values).
AFAICT, it's not possible to use parameters with CallableModel, but that contradicts some parts of the interface, e.g., compute_gradient, which implies parameters (currently CallableModel.compute_gradient always operates on a null (length-0) parameter vector; this even occurs in some of the test cases, e.g., test_callable_mean, which has a check_gradient call that operates on a null parameter vector).
Since implementing a callable model with parameters by subclassing Model is straightforward, it's unclear what the use case for the CallableModel class is, and it might be better to remove it to avoid confusion.
The text was updated successfully, but these errors were encountered:
Is the interface for
CallableModel
supposed to support parameter values? It doesn't appear that this is currently possible (it would need to be sub-classed for the user to defineparameter_names
(which is used to determinefull_size
), but then it doesn't propagate anykwargs
back toModel.__init__
for specifying parameter values).AFAICT, it's not possible to use parameters with
CallableModel
, but that contradicts some parts of the interface, e.g.,compute_gradient
, which implies parameters (currentlyCallableModel.compute_gradient
always operates on a null (length-0) parameter vector; this even occurs in some of the test cases, e.g.,test_callable_mean
, which has acheck_gradient
call that operates on a null parameter vector).Since implementing a callable model with parameters by subclassing
Model
is straightforward, it's unclear what the use case for theCallableModel
class is, and it might be better to remove it to avoid confusion.The text was updated successfully, but these errors were encountered: