Follow up items

[dfinke]

@jhoneill

utf8NoBOM

Doesn't run on PS 5.1. Not sure if this is the only PS 5 stopper.
I'm ok if this is not backward compatible.

• https://github.com/dfinke/PowerShellNotebook/blob/master/PowerShellNotebookDSL.ps1#L419

ConvertToPowerShellNoteBook.ps1

It only handles basic comments in a PS1 file for conversion to a ipynb. Not sure what the effort or how to upgrade it so comments in a function, at the end of a line won't get emitted as a markdown cell.

• nice to have

[jhoneill]

Not sure. When it was just UTF8 the ipynb would not open in VS code, it gave an error something like "bad token at position 0"
I'm fairly sure UTF8 (with BOM) opens elsewhere - including Azure data studio where one can use Windows PowerShell without installing .Net interactive. If that's the case we (cough... I) should probably file a bug against .Net Interactive because they shouldn't fail to process files which other things process successfully. Let's avoid compat issues if practical.

[dfinke]

I believe the notebook will open. The ConvertTo-PowerShellNoteBook function will fail to run on PS 5 though.