Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Superheroes example to use ordered map #1039

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Update Superheroes example to use ordered map #1039

merged 3 commits into from
Dec 3, 2024

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Nov 8, 2024

Also bump agent-js for counter app

@chenyan-dfinity chenyan-dfinity requested review from a team as code owners November 8, 2024 18:04
jessiemongeon1
jessiemongeon1 previously approved these changes Nov 8, 2024
dfx-json
dfx-json previously approved these changes Nov 8, 2024
@chenyan-dfinity chenyan-dfinity changed the title bump agent-js for counter app Update Superheroes example to use ordered map Nov 14, 2024
@marc0olo
Copy link
Member

not approving until we rely on a new dfx version which includes moc v0.13.3 that introduces OrderedMap / OrderedSet.

@marc0olo
Copy link
Member

marc0olo commented Dec 2, 2024

needs #1064

@marc0olo marc0olo merged commit 4e02cd4 into master Dec 3, 2024
4 of 6 checks passed
@marc0olo marc0olo deleted the fix-counter branch December 3, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants