merge main into z-replace (#95)

* Create pretty table (#91)

* added suggested solution for pretty_table after testing it and adding more comments

* modified function so it doesn't just take numeric cols so it's more flexible

added tests but still need to add more to them

* changed the code to account for using the latest version of pretty_num

* Improve pretty num (#89) (#90)

* added nsmall args to pretty_num and comma_sep to allow formatting of decimals

* amended the function so it takes multiple values

* updated documenation

* fixed the issue with negative dp being passed to nsmall

* changed code for testing pretty_num

* amended the documentation for comma_sep and changed expected_error to expect_equal in test_pretty_num

* fixed the - dp args problem

added nsmall to the documentation

fixed the lintr styling and complexity errors

* added extra tests to pretty_num

* fixing formtting issues for lint testing

* adding documentation, testing and extra comments for pretty_table

an extra documentation line for pretty_num came up when running workflows

* fixing the example for pretty_table by adding export

* amended the documentation to pretty_table to remove refs to the cols just being numeric, add link to the function family and linked the pretty_num function

* improved the documentation

* changed function name
added data frame test
changed the no rows from a warning to a stop
updated documentation

* updated package version, gave details on what was changed in the news.md and added myself to ctb in the description file

* fixed the bracket mistake in description,
put nsmall is code format and updated documentations

* updated the descriptions file so that i'm no longer stealing rich's academic code

* Updated default dp for pretty_num (#93)

* updated the dp default to be 0

reverted tests for pretty_num to og ones and added more tests in pretty_num

amended tests in pretty_num table

updated documentation

* applying changes to code style to pass lint check

* updated documentation

* updated formatting of documentation for spelling

* more updates to the documentation before updating package versions

* updated documentation and readme

DESCRIPTION

@@ -1,15 +1,16 @@
 Type: Package
 Package: dfeR
 Title: Common DfE R tasks
-Version: 0.5.1
+Version: 0.6.1
 Authors@R: c(
     person("Cam", "Race", , "[email protected]", role = c("aut", "cre")),
     person("Laura", "Selby", , "[email protected]", role = "aut"),
     person("Adam", "Robinson", role = "aut"),
     person("Jen", "Machin", , "[email protected]", role = "ctb"),
     person("Jake", "Tufts", , "[email protected]", role = "ctb"),
     person("Rich", "Bielby", , "[email protected]", role = "ctb",
-           comment = c(ORCID = "0000-0001-9070-9969"))
+           comment = c(ORCID = "0000-0001-9070-9969")),
+    person("Menna", "Zayed", , "[email protected]", role = "ctb")
   )
 Description: This package contains R functions to allow DfE analysts to
     re-use code for common analytical tasks that are undertaken across the

NAMESPACE

@@ -16,6 +16,7 @@ export(get_clean_sql)
 export(get_ons_api_data)
 export(pretty_filesize)
 export(pretty_num)
+export(pretty_num_table)
 export(pretty_time_taken)
 export(round_five_up)
 export(toggle_message)

NEWS.md

@@ -1,3 +1,17 @@
+# dfeR 0.6.1
+
+Patch to update the pretty_num() function so that the `dp` argument's default is 0. 
+
+# dfeR 0.6.0
+
+Update pretty_num so that: 
+
+- it can take single or multiple values. 
+- it has the argument `nsmall` that allows control over the number of digits displayed after rounding. 
+
+Add pretty_num_table() which uses pretty_num() to format numbers in a readable format in data frames. 
+It has all the customization provided by pretty_num. 
+
 # dfeR 0.5.1
 
 Patch to update the get_clean_sql() function to ignore lines starting with 'USE'.

R/pretty.R

@@ -166,7 +166,7 @@ pretty_time_taken <- function(start_time, end_time) {
 #' Uses `as.numeric()` to force a numeric value and then formats prettily
 #' for easy presentation in console messages, reports, or dashboards.
 #'
-#' This rounds to 2 decimal places by default, and adds in comma separators.
+#' This rounds to 0 decimal places by default, and adds in comma separators.
 #'
 #' Expect that this will commonly be used for adding the pound symbol,
 #' the percentage symbol, or to have a +/- prefixed based on the value.
@@ -184,11 +184,14 @@ pretty_time_taken <- function(start_time, end_time) {
 #' assign + or - based on the value
 #' @param gbp whether to add the pound symbol or not, defaults to not
 #' @param suffix suffix for the value, e.g. "%"
-#' @param dp number of decimal places to round to, 2 by default
+#' @param dp number of decimal places to round to, 0 by default.
 #' @param ignore_na whether to skip function for strings that can't be
 #' converted and return original value
 #' @param alt_na alternative value to return in place of NA, e.g. "x"
-#' @param nsmall minimum number of digits to the right of the decimal point
+#' @param nsmall minimum number of digits to the right of the decimal point.
+#' If NULL, the value of `dp` will be used.
+#' If the value of `dp` is less than 0, then `nsmall` will
+#' automatically be set to 0.
 #'
 #' @return string featuring prettified value
 #' @family prettying
@@ -223,7 +226,7 @@ pretty_num <- function(
     prefix = "",
     gbp = FALSE,
     suffix = "",
-    dp = 2,
+    dp = 0,
     ignore_na = FALSE,
     alt_na = FALSE,
     nsmall = NULL) {
@@ -265,6 +268,7 @@ pretty_num <- function(
 
     # Add suffix and prefix, plus convert to million or billion
 
+
     # If nsmall is not given, make same value as dp
     # if dp is smaller than 0, make nsmall 0
     # if nsmall is specified, use that value
@@ -313,3 +317,100 @@ pretty_num <- function(
   # unlisting the results so that they're all on one line
   return(unlist(result))
 }
+
+#' Format a data frame with `dfeR::pretty_num()`.
+#'
+#' You can format number and character values in a data frame
+#' by passing arguments to `dfeR::pretty_num()`.
+#' Use parameters `include_columns` or `exclude_columns`
+#' to specify columns for formatting.
+#'
+#' @param data A data frame containing the columns to be formatted.
+#' @param include_columns A character vector specifying which columns to format.
+#' If `NULL` (default), all columns will be considered for formatting.
+#' @param exclude_columns A character vector specifying columns to exclude
+#' from formatting.
+#' If `NULL` (default), no columns will be excluded.
+#' If both `include_columns` and `exclude_columns` are provided
+#' , `include_columns` takes precedence.
+#' @param ... Additional arguments passed to `dfeR::pretty_num()`
+#' , such as `dp` (decimal places)
+#' for controlling the number of decimal points.
+#'
+#' @return A data frame with columns formatted using `dfeR::pretty_num()`.
+#'
+#' @details
+#' The function first checks if any columns are specified for inclusion
+#' via `include_columns`.
+#' If none are provided, it checks if columns are specified for exclusion
+#' via `exclude_columns`.
+#' If neither is specified, all columns in the data frame are formatted.
+#' @family prettying
+#' @seealso [pretty_num()]
+#' @export
+#' @examples
+#' # Example data frame
+#' df <- data.frame(
+#'   a = c(1.234, 5.678, 9.1011),
+#'   b = c(10.1112, 20.1314, 30.1516),
+#'   c = c("A", "B", "C")
+#' )
+#'
+#' # Apply formatting to all columns
+#' pretty_num_table(df, dp = 2)
+#'
+#' # Apply formatting to only selected columns
+#' pretty_num_table(df, include_columns = c("a"), dp = 2)
+#'
+#' # Apply formatting to all columns except specified ones
+#' pretty_num_table(df, exclude_columns = c("b"), dp = 2)
+#'
+#' # Apply formatting to all columns except specified ones and
+#' # provide alternative value for NAs
+#' pretty_num_table(df, alt_na = "[z]", exclude_columns = c("b"), dp = 2)
+#'
+pretty_num_table <- function(data,
+                             include_columns = NULL,
+                             exclude_columns = NULL,
+                             ...) {
+  # Check data is a data frame and throw error if not
+  if (!is.data.frame(data)) {
+    stop(paste0(
+      "Data has the class ", class(data),
+      ", data must be a data.frame object"
+    ))
+  }
+
+  # Check if the data frame has rows - if not, stop the process
+  if (nrow(data) < 1) {
+    stop("Data frame is empty or contains no rows.")
+  }
+
+  # Determine which columns to include based on the provided parameters
+
+  # if the include_columns arg is specified
+  if (!is.null(include_columns)) {
+    # assign the names to the cols_to_include variable
+    cols_to_include <- include_columns
+
+    # if the exclude_columns arg is specified
+  } else if (!is.null(exclude_columns)) {
+    # we assign the cols_to_include to names of all columns
+    # except for ones specified in exclude_columns
+    cols_to_include <- setdiff(
+      names(data),
+      exclude_columns
+    )
+  } else {
+    # if none of the previous conditions are met
+    # all columns are assigned to cols_to_include
+    cols_to_include <- names(data)
+  }
+
+  # Apply pretty_num() formatting to the selected columns
+  data %>%
+    dplyr::mutate(dplyr::across(
+      .cols = dplyr::all_of(cols_to_include),
+      ~ pretty_num(., ...)
+    ))
+}

tests/testthat/test-pretty_num.R

@@ -1,19 +1,21 @@
 test_that("prettifies", {
-  expect_equal(pretty_num(1, gbp = TRUE, suffix = " offer"), "£1.00 offer")
-  expect_equal(pretty_num(-1), "-1.00")
-  expect_equal(pretty_num(-1, prefix = "-"), "--1.00")
-  expect_equal(pretty_num(-1, prefix = "+/-"), "-1.00")
-  expect_equal(pretty_num(1, prefix = "+/-"), "+1.00")
-  expect_equal(pretty_num(12.289009, suffix = "%"), "12.29%")
-  expect_equal(pretty_num(1000), "1,000.00")
+  expect_equal(pretty_num(1, gbp = TRUE, suffix = " offer"), "£1 offer")
+  expect_equal(pretty_num(-1, dp = 2), "-1.00")
+  expect_equal(pretty_num(-1), "-1")
+  expect_equal(pretty_num(-1, prefix = "-"), "--1")
+  expect_equal(pretty_num(-1, prefix = "+/-"), "-1")
+  expect_equal(pretty_num(-1, dp = 2, prefix = "+/-"), "-1.00")
+  expect_equal(pretty_num(1, prefix = "+/-"), "+1")
+  expect_equal(pretty_num(12.289009, dp = 2, suffix = "%"), "12.29%")
+  expect_equal(pretty_num(1000), "1,000")
   expect_equal(pretty_num(11^8, gbp = TRUE, dp = -1), "£210 million")
   expect_equal(pretty_num(11^9, gbp = TRUE, dp = 3), "£2.358 billion")
   expect_equal(pretty_num(-11^8, gbp = TRUE, dp = -1), "-£210 million")
-  expect_equal(pretty_num(-123421421), "-123.42 million")
+  expect_equal(pretty_num(-123421421, dp = 2), "-123.42 million")
   expect_equal(pretty_num(63.71, dp = 1, nsmall = 2), "63.70")
   expect_equal(pretty_num(894.1, dp = 2, nsmall = 3), "894.100")
   expect_equal(
-    pretty_num(11^8, prefix = "+/-", gbp = TRUE, dp = -1.00), "+£210 million"
+    pretty_num(11^8, prefix = "+/-", gbp = TRUE, dp = -1), "+£210 million"
   )
 })
 
@@ -27,11 +29,16 @@ test_that("handles NAs", {
 test_that("tests multiple values", {
   expect_equal(
     pretty_num(c(1:4)),
-    c("1.00", "2.00", "3.00", "4.00")
+    c("1", "2", "3", "4")
   )
 
   expect_equal(
     pretty_num(c(1:4), nsmall = 1),
     c("1.0", "2.0", "3.0", "4.0")
   )
+
+  expect_equal(
+    pretty_num(c(1.478, 7.38897, 8.37892), dp = 1, nsmall = 2),
+    c("1.50", "7.40", "8.40")
+  )
 })