Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractSample misidentifies parent element #36

Open
KartikChugh opened this issue Jul 13, 2018 · 3 comments
Open

extractSample misidentifies parent element #36

KartikChugh opened this issue Jul 13, 2018 · 3 comments
Labels
bug High Priority

Comments

@KartikChugh
Copy link
Collaborator

KartikChugh commented Jul 13, 2018 •
edited
Loading

Says parentTag is ul instead of li:

<ul class='navigation'>
      <li><a href='http://discuss.atom.io'>Discuss</a></li>
      <li><|</li>
</ul>

<ul class='navigation'>
      <li><a href='http://discuss.atom.io'>Discuss</a></li>
      <li>
      <|</li>
</ul>
@KartikChugh
Copy link
Collaborator Author

Correctly identifies li as parentTag here, though:

<ul class='navigation'>
      <li><a href='http://discuss.atom.io'>Discuss</a></li>
      <li><|
      </li>
</ul>

@KartikChugh KartikChugh changed the title extractSample gets data for grandparents if typing is done on same line as close tag extractSample misidentifies parent element if typing is done on same line as close tag Jul 16, 2018
@KartikChugh KartikChugh reopened this Jul 22, 2018
@KartikChugh KartikChugh changed the title extractSample misidentifies parent element if typing is done on same line as close tag extractSample misidentifies parent element Jul 22, 2018
@KartikChugh
Copy link
Collaborator Author

New validation logs indicates misidentification of parents

@KartikChugh
Copy link
Collaborator Author

Possibly resolved in light of recent updates?

@KartikChugh KartikChugh mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KartikChugh