-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cm secret patch dry run #421
Open
RohitRaj011
wants to merge
14
commits into
feat/patch-dt
Choose a base branch
from
feat/cm-secret-patch-dry-run
base: feat/patch-dt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmon-lib into feat/cm-secret-patch-dry-run
…mmon-lib into feat/cm-secret-patch-dry-run
…mmon-lib into feat/cm-secret-patch-dry-run
…mmon-lib into feat/cm-secret-patch-dry-run
RohitRaj011
requested review from
vikramdevtron and
vivek-devtron
as code owners
November 25, 2024 05:08
@@ -276,16 +276,31 @@ export const useForm = <T extends Record<keyof T, any> = {}>(options?: { | |||
keepTouched?: boolean | |||
/** A boolean indicating whether to retain the current error state of the form fields. */ | |||
keepErrors?: boolean | |||
|
|||
triggerDirty?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: can add comment
vivek-devtron
approved these changes
Nov 25, 2024
…gating, useForm - documentation and reset options update
…mmon-lib into feat/cm-secret-patch-dry-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist