chore: add type for accumulator in get profile service

devtron-labs · Jan 29, 2024 · 5654ee9 · 5654ee9
1 parent 303b73a
commit 5654ee9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/Pages/GlobalConfigurations/BuildInfra/services.tsx b/src/Pages/GlobalConfigurations/BuildInfra/services.tsx
@@ -14,6 +14,7 @@ import {
     CreateBuildInfraServiceConfigurationType,
     GetBuildInfraProfileType,
     UpdateBuildInfraProfileType,
+    BuildInfraConfigurationMapWithoutDefaultType,
 } from './types'
 
 const getBaseProfileObject = (
@@ -45,13 +46,13 @@ export const getTransformedBuildInfraProfileResponse = ({
         defaultConfigurations?.reduce((acc, configuration) => {
             acc[configuration.key] = configuration
             return acc
-        }, {}) ?? {}
+        }, {} as BuildInfraConfigurationMapWithoutDefaultType) ?? ({} as BuildInfraConfigurationMapWithoutDefaultType)
 
     const profileConfigurations =
         profile?.configurations?.reduce((acc, configuration) => {
             acc[configuration.key] = configuration
             return acc
-        }, {}) ?? {}
+        }, {} as BuildInfraConfigurationMapWithoutDefaultType) ?? ({} as BuildInfraConfigurationMapWithoutDefaultType)
 
     const configurations = Object.keys(defaultConfigurationsMap).reduce((acc, key) => {
         const defaultConfiguration: BuildInfraConfigurationType = defaultConfigurationsMap[key]

diff --git a/src/Pages/GlobalConfigurations/BuildInfra/types.tsx b/src/Pages/GlobalConfigurations/BuildInfra/types.tsx
@@ -145,6 +145,10 @@ export interface BuildInfraConfigurationType extends BuildInfraConfigValuesType,
     defaultValue: BuildInfraConfigValuesType
 }
 
+export type BuildInfraConfigurationMapWithoutDefaultType = {
+    [key in BuildInfraConfigTypes]: BuildInfraConfigValuesType & BuildInfraProfileConfigBase
+}
+
 export type BuildInfraConfigurationMapType = {
     [key in BuildInfraConfigTypes]: BuildInfraConfigurationType
 }

diff --git a/src/Pages/GlobalConfigurations/BuildInfra/utils.tsx b/src/Pages/GlobalConfigurations/BuildInfra/utils.tsx
@@ -210,6 +210,7 @@ export const useBuildInfraForm = ({
                 currentInputErrors[BuildInfraConfigTypes.CPU_REQUEST] = request.message
                 break
             }
+
             case BuildInfraConfigTypes.CPU_REQUEST: {
                 currentConfiguration[BuildInfraConfigTypes.CPU_REQUEST] = {
                     ...currentConfiguration[BuildInfraConfigTypes.CPU_REQUEST],