Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the quick start instructions need updating #509

Closed
LTLA opened this issue Apr 17, 2024 · 2 comments
Closed

Some of the quick start instructions need updating #509

LTLA opened this issue Apr 17, 2024 · 2 comments

Comments

@LTLA
Copy link

LTLA commented Apr 17, 2024

(Part of openjournals/joss-reviews#6617)

The Hello World example requires the submodules in third-party to be fetched. This is not done automatically on the initial git clone, at least not on my version of Git.

The header file names in Base tools are not correct (.h instead of .hpp).

And unrelated, but the title here has a typo ("Empirica's").

@mmore500
Copy link
Member

mmore500 commented Apr 18, 2024

Thanks for bringing these issues to our attention!

Just opened #514 with fixes for the three issues mentioned. When it merges, this issue will close. However, feel free to re-open if you find more lint or the issues are not adequately addressed 👍

@mmore500
Copy link
Member

Closed by #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants