Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Cluster #8 in "Done" #85

Open
deniseddi opened this issue May 19, 2020 · 3 comments
Open

ECS Cluster #8 in "Done" #85

deniseddi opened this issue May 19, 2020 · 3 comments
Assignees

Comments

@deniseddi
Copy link
Contributor

Are we good with those?

Requirements:

  • one instance is fine for demonstration, ideally two instances on different AZ’s
  • any security group or IAM permissions should be very restrictive with only required permissions
@faria-marcio
Copy link
Contributor

This one, yes

  • [ one instance is fine for demonstration, ideally two instances on different AZ’s ]

For this:

  • [ any security group or IAM permissions should be very restrictive with only required permissions ]
    I'm afraid not as we have these three IAMs permissions for TD and EC2 instances. I don't think we need all three for both.
    arn:aws:iam::aws:policy/AmazonSSMReadOnlyAccess", "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role", "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"

I guess the SGs could be more restrictive.

@drii-cavalcanti
Copy link

This one, yes

  • [ one instance is fine for demonstration, ideally two instances on different AZ’s ]

For this:

  • [ any security group or IAM permissions should be very restrictive with only required permissions ]
    I'm afraid not as we have these three IAMs permissions for TD and EC2 instances. I don't think we need all three for both.
    arn:aws:iam::aws:policy/AmazonSSMReadOnlyAccess", "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role", "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"

I guess the SGs could be more restrictive.

I agree with Marcio! I will have a look at those sg's.

@drii-cavalcanti
Copy link

drii-cavalcanti commented May 20, 2020

iam_policy_arn_task = ["arn:aws:iam::aws:policy/AmazonSSMReadOnlyAccess",
"arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role",
> #"arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy",
"arn:aws:iam::aws:policy/CloudWatchLogsFullAccess"
]

iam_policy_arn_ec2 = ["arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role",
> #"arn:aws:iam::aws:policy/AmazonSSMReadOnlyAccess",
#"arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"

]

It worked for me just removing those policies... I understand the best way would be to go deeper and to set each resource to its adequate policy and action. However, let's keep fixing those other issues once this one takes to long to verify what the action and the policy are.

@faria-marcio faria-marcio self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants