Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put file size validator into pre validation check #111

Open
vergeev opened this issue Apr 16, 2018 · 0 comments
Open

Put file size validator into pre validation check #111

vergeev opened this issue Apr 16, 2018 · 0 comments

Comments

@vergeev
Copy link
Contributor

vergeev commented Apr 16, 2018

The validator has_no_long_files counts the number of lines. But it might be too late if fiasko encounters a really big file: it first will try to parse it and only then run the validator. To avoid this situation, I'm suggesting to put the validator into pre-validator check category.

Ranc58 added a commit to Ranc58/fiasko_bro that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant