Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: recognize domain specific words #2273

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

densumesh
Copy link
Contributor

Please indicate what issue this PR is related to and @ any maintainers who are relevant

@densumesh densumesh force-pushed the ds/recognize-domain-specific-words branch 2 times, most recently from a63d68c to 02427f1 Compare August 31, 2024 23:50
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dependency removals here intentional?

@densumesh
Copy link
Contributor Author

Are the dependency removals here intentional?

Yes they are. No longer using bloom filters and bktree functions have been moved into our code

@skeptrunedev skeptrunedev force-pushed the ds/recognize-domain-specific-words branch 2 times, most recently from 0c020cb to 897a46d Compare September 2, 2024 22:32
@skeptrunedev skeptrunedev self-requested a review September 2, 2024 22:32
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new request param needs to get added to options popover

@skeptrunedev skeptrunedev force-pushed the ds/recognize-domain-specific-words branch from b66122d to 3dc1cef Compare September 3, 2024 19:12
@skeptrunedev skeptrunedev force-pushed the ds/recognize-domain-specific-words branch from 3dc1cef to e35d01d Compare September 3, 2024 19:21
@skeptrunedev skeptrunedev force-pushed the ds/recognize-domain-specific-words branch from e35d01d to 3c988bf Compare September 3, 2024 19:27
@skeptrunedev skeptrunedev self-requested a review September 3, 2024 19:28
@skeptrunedev skeptrunedev merged commit a96bd22 into main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants