cleanup remove Union types caused by V2 response type upgrade

devflowinc · Oct 6, 2024 · d944862 · d944862
1 parent 3c2187d
commit d944862
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 15 deletions.
diff --git a/clients/ts-sdk/src/functions/chunks/chunk.test.ts b/clients/ts-sdk/src/functions/chunks/chunk.test.ts
@@ -3,11 +3,10 @@ import { TrieveSDK } from "../../sdk";
 import {
   ChunkReturnTypes,
   CountChunkQueryResponseBody,
-  RecommendResponseTypes,
+  RecommendChunksResponseBody,
   ReturnQueuedChunk,
   ScrollChunksResponseBody,
   SearchResponseBody,
-  SearchResponseTypes,
 } from "../../types.gen";
 import {
   CHUNK_EXAMPLE_ID,
@@ -44,15 +43,15 @@ describe("Chunk Methods Test", async () => {
       search_type: "fulltext",
     });
 
-    expectTypeOf(data).toEqualTypeOf<SearchResponseTypes>();
+    expectTypeOf(data).toEqualTypeOf<SearchResponseBody>();
   });
 
   test("getRecommendedChunks", async () => {
     const data = await trieve.getRecommendedChunks({
       positive_chunk_ids: [CHUNK_EXAMPLE_ID],
     });
 
-    expectTypeOf(data).toEqualTypeOf<RecommendResponseTypes>();
+    expectTypeOf(data).toEqualTypeOf<RecommendChunksResponseBody>();
   });
 
   test("ragOnChunk", async () => {

diff --git a/clients/ts-sdk/src/functions/chunks/index.ts b/clients/ts-sdk/src/functions/chunks/index.ts
@@ -16,6 +16,7 @@ import {
   GetChunksData,
   GetTrackingChunksData,
   RecommendChunksRequest,
+  RecommendChunksResponseBody,
   ScrollChunksReqPayload,
   SearchChunksReqPayload,
   SearchResponseBody,
@@ -114,7 +115,7 @@ export async function autocomplete(
       xApiVersion: "V2",
     },
     signal
-  );
+  ) as Promise<SearchResponseBody>;
 }
 
 /**
@@ -143,7 +144,7 @@ export async function getRecommendedChunks(
       datasetId: this.datasetId,
     },
     signal
-  );
+  ) as Promise<RecommendChunksResponseBody>;
 }
 
 /**

diff --git a/clients/ts-sdk/src/functions/groups/chunkGroup.test.ts b/clients/ts-sdk/src/functions/groups/chunkGroup.test.ts
@@ -11,9 +11,9 @@ import {
   GetChunksInGroupResponse,
   GroupData,
   GroupsForChunk,
-  RecommendGroupsResponse,
-  SearchGroupResponseTypes,
-  SearchOverGroupsResponseTypes,
+  RecommendGroupsResponseBody,
+  SearchOverGroupsResponseBody,
+  SearchWithinGroupResponseBody,
 } from "../../types.gen";
 import { test } from "../../__tests__/utils";
 
@@ -37,7 +37,7 @@ describe("Chunk Groups Methods Test", async () => {
       search_type: "fulltext",
     });
 
-    expectTypeOf(data).toEqualTypeOf<SearchOverGroupsResponseTypes>();
+    expectTypeOf(data).toEqualTypeOf<SearchOverGroupsResponseBody>();
   });
   test("searchInGroup", async () => {
     const data = await trieve.searchInGroup({
@@ -46,14 +46,14 @@ describe("Chunk Groups Methods Test", async () => {
       group_id: GROUP_EXAMPLE_ID,
     });
 
-    expectTypeOf(data).toEqualTypeOf<SearchGroupResponseTypes>();
+    expectTypeOf(data).toEqualTypeOf<SearchWithinGroupResponseBody>();
   });
   test("recommendedGroups", async () => {
     const data = await trieve.recommendedGroups({
       positive_group_ids: [GROUP_EXAMPLE_ID],
     });
 
-    expectTypeOf(data).toEqualTypeOf<RecommendGroupsResponse>();
+    expectTypeOf(data).toEqualTypeOf<RecommendGroupsResponseBody>();
   });
   test("updateGroup", async () => {
     const data = await trieve.updateGroup({

diff --git a/clients/ts-sdk/src/functions/groups/index.ts b/clients/ts-sdk/src/functions/groups/index.ts
@@ -16,9 +16,12 @@ import {
   GetGroupsForChunksReqPayload,
   GetGroupsForDatasetData,
   RecommendGroupsReqPayload,
+  RecommendGroupsResponseBody,
   RemoveChunkFromGroupReqPayload,
   SearchOverGroupsReqPayload,
+  SearchOverGroupsResponseBody,
   SearchWithinGroupReqPayload,
+  SearchWithinGroupResponseBody,
   UpdateChunkGroupReqPayload,
   UpdateGroupByTrackingIDReqPayload,
 } from "../../fetch-client";
@@ -77,7 +80,7 @@ export async function searchOverGroups(
       datasetId: this.datasetId,
     },
     signal
-  );
+  ) as Promise<SearchOverGroupsResponseBody>;
 }
 
 /**
@@ -104,7 +107,7 @@ export async function searchInGroup(
       datasetId: this.datasetId,
     },
     signal
-  );
+  ) as Promise<SearchWithinGroupResponseBody>;
 }
 
 /**
@@ -131,7 +134,7 @@ export async function recommendedGroups(
       datasetId: this.datasetId,
     },
     signal
-  );
+  ) as Promise<RecommendGroupsResponseBody>;
 }
 
 /**