You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should use this to validate the commands present in a devworkspace during the devworkspace reconciliation. We should also use this validation in the validating webhook.
Not only would this catch invalid devfile's provided by users, but it would prevent any errors when DWO injects invalid commands into the devworkspace, as was mentioned in #1329 (comment) where commands with the same ID were being injected into the devworkspace.
Currently, the following devworkspace will be start, despite having 2 commands with the same ID:
I'd expect the above devworkspace to fail, citing commands with duplicate IDs (which is not permitted by the devfile API).
The text was updated successfully, but these errors were encountered:
AObuchow
changed the title
Valid commands in devworkspaces using devfile validation package
Validate commands in devworkspaces using devfile validation package
Oct 31, 2024
Description
The devfile API provides a validation package that can be used to validate devfile commands.
We should use this to validate the commands present in a devworkspace during the devworkspace reconciliation. We should also use this validation in the validating webhook.
Not only would this catch invalid devfile's provided by users, but it would prevent any errors when DWO injects invalid commands into the devworkspace, as was mentioned in #1329 (comment) where commands with the same ID were being injected into the devworkspace.
Currently, the following devworkspace will be start, despite having 2 commands with the same ID:
I'd expect the above devworkspace to fail, citing commands with duplicate IDs (which is not permitted by the devfile API).
The text was updated successfully, but these errors were encountered: