Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to DWO-injected commands that should not be displayed to users #1333

Open
AObuchow opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AObuchow
Copy link
Collaborator

Description

#1307 & #1329 added commands to devworkspaces with the name format init-ssh-agent-command-x. These commands are meant to be run automatically as postStart commands, rather than being invoked by users manually.

Currently, in Che we are [filtering out](che-incubator/che-code#445 these specific commands in the editor so that they are not displayed in the commands list.

However, a better approach would be to add an attribute to all DWO-injected commands that should not be displayed to the user. For example, controller.devfile.io/internal-command: true.

Additional context

Thank you for the suggestion @RomanNikitenko :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant