Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderRemoteData type wrong inferring on TS 3.3.3 #114

Open
scink opened this issue Feb 12, 2019 · 6 comments
Open

RenderRemoteData type wrong inferring on TS 3.3.3 #114

scink opened this issue Feb 12, 2019 · 6 comments

Comments

@scink
Copy link
Contributor

scink commented Feb 12, 2019

on the TS 3.3.3 if we use isEmpty from fp-ts for noData prop we have these errors
screen shot 2019-02-12 at 13 08 17
screen shot 2019-02-12 at 13 08 26
@scink scink added the bug label Feb 12, 2019
@raveclassic
Copy link
Contributor

What is the full inferred type of data?

@raveclassic
Copy link
Contributor

Could you provide a minimal gist for this?

@scink
Copy link
Contributor Author

scink commented Feb 12, 2019

data is RemoteData<Error, TMarketStateTableRecord[]>.
i'll try to create a gist

@scink
Copy link
Contributor Author

scink commented Feb 13, 2019

totally forgot: there is a bag only if use pass isEmpty as link. with noData={a => isEmpty(a)} everything is fine

@scink
Copy link
Contributor Author

scink commented Feb 13, 2019

https://gist.github.com/scink/689da03059c5a3eaf5fcb258db176dda
gist

@raveclassic
Copy link
Contributor

So I suppose it's not a bug but TS behavior then

@raveclassic raveclassic removed the bug label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raveclassic @scink