Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch #1167

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

ashk1996
Copy link
Contributor

@ashk1996 ashk1996 commented Oct 2, 2024

Removed readonly state and css for the above components

Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashk1996 , PR looks good to me, before merging, we also need to do the design changes. Please contact @larserbach for this

@ashk1996
Copy link
Contributor Author

ashk1996 commented Oct 7, 2024

Hi @thrbnhrtmnn
I've synced with Lars, tokens have been removed and we are ready to merge

@thrbnhrtmnn thrbnhrtmnn merged commit 9f9585c into develop Oct 7, 2024
4 of 5 checks passed
@thrbnhrtmnn thrbnhrtmnn deleted the fix/832_remove-readonly-state branch October 7, 2024 15:35
larserbach added a commit that referenced this pull request Oct 8, 2024
… and toggle switch (#1167)

* fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch

* rmv readonly tokens from checkbox, radio, radiogroup and toggleswitch

* fixes radio css

---------

Co-authored-by: Lars Erbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants