You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Hello,
I finally got around to updating our toolkit version as I got tired of the issues with the PHPDoc's of the old version I was using and wanted to get us up to date.
I see many of the issues have been fixed, but there are still glaring issues with the code that any good IDE identifies immediately!
There are a few methods like partner client sendSingleEmail that use uninitialized variables like so:
$arg->messages = $messages;
$arg was never created... And due to the questionable behavior of PHP, the code likely 'works', but is still wrong.
So to clean up the code, please open the code base in an IDE and fix the issues inspections are alerting on where possible (Sadly the use of relying on SoapClient for Class generation is going to result in many unknown classes)
But overall glad to see the docs mostly right now.
The text was updated successfully, but these errors were encountered:
Hello,
I finally got around to updating our toolkit version as I got tired of the issues with the PHPDoc's of the old version I was using and wanted to get us up to date.
I see many of the issues have been fixed, but there are still glaring issues with the code that any good IDE identifies immediately!
There are a few methods like partner client sendSingleEmail that use uninitialized variables like so:
$arg->messages = $messages;
$arg was never created... And due to the questionable behavior of PHP, the code likely 'works', but is still wrong.
Many doc blocks also miss $ like so:
So to clean up the code, please open the code base in an IDE and fix the issues inspections are alerting on where possible (Sadly the use of relying on SoapClient for Class generation is going to result in many unknown classes)
But overall glad to see the docs mostly right now.
The text was updated successfully, but these errors were encountered: