Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Numerous code and doc issues #45

Open
aikar opened this issue Oct 16, 2015 · 0 comments
Open

Numerous code and doc issues #45

aikar opened this issue Oct 16, 2015 · 0 comments

Comments

@aikar
Copy link

aikar commented Oct 16, 2015

Hello,
I finally got around to updating our toolkit version as I got tired of the issues with the PHPDoc's of the old version I was using and wanted to get us up to date.

I see many of the issues have been fixed, but there are still glaring issues with the code that any good IDE identifies immediately!

There are a few methods like partner client sendSingleEmail that use uninitialized variables like so:

$arg->messages = $messages;

$arg was never created... And due to the questionable behavior of PHP, the code likely 'works', but is still wrong.

Many doc blocks also miss $ like so:

  • @param array sObjects Array of sObjects

So to clean up the code, please open the code base in an IDE and fix the issues inspections are alerting on where possible (Sadly the use of relying on SoapClient for Class generation is going to result in many unknown classes)

But overall glad to see the docs mostly right now.

@uuf6429 uuf6429 mentioned this issue Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant