Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider RestClient throw on real network errors #17

Open
detunized opened this issue Jan 15, 2020 · 0 comments
Open

Consider RestClient throw on real network errors #17

detunized opened this issue Jan 15, 2020 · 0 comments

Comments

@detunized
Copy link
Owner

Currently RestClient doesn't throw at all. This is by design. This way it's easy to handle non-2XX HTTP status codes. On the flip side, we have to manually handle network errors everywhere. Normally those are thrown right away and never handled by the library. Usually these errors indicate problems like lack of connectivity or DNS failure. No reason to handle this in the lib. Let the app handle it and just throw directly from RestClient. This would also make a lot of tests unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant