Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning / upgrading Envoy version in Golang filter #45

Open
dettanym opened this issue Oct 19, 2023 · 1 comment
Open

Pinning / upgrading Envoy version in Golang filter #45

dettanym opened this issue Oct 19, 2023 · 1 comment
Labels
wontfix This will not be worked on

Comments

@dettanym
Copy link
Owner

The Envoy versions in these three files need to be compatible:

  • Golang Envoy API headers in go.mod file
  • Istio proxy version that our custom image builds off of.

So the older version of Envoy in the go.mod file is the one that Istio loads. It's necessary to use this version so that the StreamFilter API that is implemented by our Golang filter, and the resulting .so file, can be loaded and executed by the Envoy proxy inside Istio. Otherwise we get linker and runtime errors.

@qlonik
Copy link
Collaborator

qlonik commented Feb 27, 2024

We updated all components in tandem to compatible versions.

See #90, 1be0f45, e98cae9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants