-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix split test files ci #1316
Conversation
WalkthroughThe recent update enhances a GitHub Actions workflow by ensuring that Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test.yml (1 hunks)
Additional Context Used
Additional comments not posted (1)
.github/workflows/test.yml (1)
73-73
: The addition ofgo mod tidy &&
beforego list ./... > pkgs.txt
is a good practice to ensure thego.mod
file is up-to-date, addressing the CI failure issue effectively. However, it's advisable to monitor the CI job's execution time after this change to ensure it does not introduce significant delays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Description
Closes: #XXXX
This PR fixes the CI of splitting test files, currently, it always fails since it requires
go mod tidy
to updatego.mod
beforego list
.https://github.com/desmos-labs/desmos/actions/runs/8479093667/job/23232524696?pr=1309#step:3:172
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
go mod tidy
before listing packages to ensure a tidy module list.