Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMfit VAC Review (DR1) #29

Open
3 of 4 tasks
dylanagreen opened this issue Dec 30, 2024 · 1 comment
Open
3 of 4 tasks

EMfit VAC Review (DR1) #29

dylanagreen opened this issue Dec 30, 2024 · 1 comment
Assignees
Labels
vac review Issues pertaining to VAC reviews

Comments

@dylanagreen
Copy link

Contact Person: Raga Pucha
2? catalog file (fits), 1 README

Initial Checks:

  • Includes README
  • Columns in ALLCAPS
  • Extension names in ALLCAPS (see below)
  • Files include units

Initial Notes:

  • File is looking good so far! Can you please add the units indicated in the README to the respective columns in the actual data file?
  • Don't forget to add an extension name (in ALLCAPS) to the fits file so that the header can be referenced by name rather than index.
  • README looks good, no notes at this time.
  • The file directory includes a fuji emfit file. Nominally we want DR1 VACs to be on guadalupe or iron, will this file be superseded by the iron version when it's done?
@dylanagreen dylanagreen self-assigned this Dec 30, 2024
@weaverba137
Copy link
Member

Note that there is a related PR: desihub/desidatadocs#85. Please make sure that the PR is updated to match the final README file.

@dylanagreen dylanagreen added the vac review Issues pertaining to VAC reviews label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vac review Issues pertaining to VAC reviews
Projects
None yet
Development

No branches or pull requests

2 participants