Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Highlight] partially broken within tpope/vim-markdown fenced code #157

Open
Huxpro opened this issue Jul 10, 2019 · 3 comments
Open

[Highlight] partially broken within tpope/vim-markdown fenced code #157

Huxpro opened this issue Jul 10, 2019 · 3 comments

Comments

@Huxpro
Copy link

Huxpro commented Jul 10, 2019

Screen Shot 2019-07-09 at 8 37 52 PM

vim-markdown supports fenced code highlight with in markdown.
the problem is that vim-scala syntax works well for filetype=scala but partially broken inside filetype=markdown.

It's reproducible for code like object ID { or def Foo() {.
I assumed it's something related to brackets since adding // } would revoke highlights below this line.

I think it might related to the dynamics of vim-scala/syntax here:

exe 'syn region scalaBlock start=/{/ end=/}/ contains=' . s:ContainedGroup() . ' fold'

I am not sure what's the problem so I fired issues on both side:
vim-markdown: tpope/vim-markdown#142
vim-scala: #157

@Huxpro Huxpro changed the title [highlight] Not work well with tpope/vim-markdown fenced code [Highlight] partially broken within tpope/vim-markdown fenced code Jul 10, 2019
@Huxpro Huxpro closed this as completed Oct 4, 2019
@benknoble
Copy link

@Huxpro why did you close the issues? Did you resolve it somehow?

@ches
Copy link
Collaborator

ches commented Nov 4, 2019

Can still reproduce this on current master, so I'll re-open.

@ches ches reopened this Nov 4, 2019
@Huxpro
Copy link
Author

Huxpro commented Nov 5, 2019

@benknoble I thought no one is maintaining and interested in this lol. Thx for reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants