Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): improve error message on script timeout #861

Closed
padmavemulapati opened this issue Oct 11, 2023 · 1 comment
Closed

feat(cli): improve error message on script timeout #861

padmavemulapati opened this issue Oct 11, 2023 · 1 comment

Comments

@padmavemulapati
Copy link

padmavemulapati commented Oct 11, 2023

Product

cli

Feature Description

Previously a script timeout error just displayed a stack trace without any information on the current timeout or how to change the timeout.

#PR

@padmavemulapati
Copy link
Author

padmavemulapati commented Oct 11, 2023

Valdiated with the canary build - @axe-core/npm_4.7.4-62fd241.0

For Script-timeout, error message is improved more better saying -
"The timeout is currently configured to be 00 seconds (you can change it with --timeout)."

  1. Valdiated with timeout 00 and also timeout with decimal value
MacBook-Pro:cli dq_user$  axe www.cnn.com --timeout=00
Running axe-core 4.8.2 in chrome-headless

Testing http://www.cnn.com ... please wait, this may take a minute.
Error: script timeout
  (Session info: headless chrome=117.0.5938.149)
The timeout is currently configured to be 00 seconds (you can change it with --timeout).
MacBook-Pro:cli dq_user$  axe www.cnn.com --timeout=0.1
Running axe-core 4.8.2 in chrome-headless

Testing http://www.cnn.com ... please wait, this may take a minute.
Error: script timeout
  (Session info: headless chrome=117.0.5938.149)
The timeout is currently configured to be 0.1 seconds (you can change it with --timeout).

Screenshot

image
  1. Valdiated for timeout 0 (which cannt be carry any value as timeout value should be in milliseconds)
MacBook-Pro:cli dq_user$ axe www.cnn.com --timeout 0
Running axe-core 4.8.2 in chrome-headless

Testing http://www.cnn.com ... please wait, this may take a minute.
Error: script timeout
  (Session info: headless chrome=117.0.5938.149)
The timeout is currently configured to be 0 seconds (you can change it with --timeout).

Environment:

Label Value
Product axe-core-npm/cli
Version 4.7.4-62fd241.0
OS-Details _MAC- Intel Core i7 - 11.6.8 & Windows11 _
BrowserDetails Chrome Version 117.0.5938.88 (Official Build) (64-bit) & Firefox 117.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant