Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Can't see soy build errors on lerna run soy #58

Open
carloslancha opened this issue Aug 29, 2017 · 0 comments
Open

Can't see soy build errors on lerna run soy #58

carloslancha opened this issue Aug 29, 2017 · 0 comments

Comments

@carloslancha
Copy link
Collaborator

When running npm test first action executed is lerna run soy. If there're any soy errors they won't show up in console. i.e:

  • Add not used parameter in packages/clay-button/src/ClayButton.soy
{@param? type: string}
{@param? value: string}
{@param? notUsedParam: string}
  • Run npm test from root. Should appear an error like:
FAIL  packages/clay-button/src/__tests__/ClayButton.js
  Test suite failed to run
    Cannot find module './ClayButton.soy.js' from 'ClayButton.js'
      
      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:179:17)
      at Object.<anonymous> (packages/clay-select/src/ClayButton.js:7:22)
  • That's because ClayButton.soy.js wasn't generated due build errors, but nothing warns you about those errors at least you run npm run build inside the package.
Compiling soy
Error in plugin 'metal-tools-soy'
Message:
    Compile error:
errors during Soy compilation
src/ClayButton.soy:6: error: Param 'notUsedParam' unused in template body.
{template .render}
^
1 error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant