Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Development] Align List styles to USWDS #3396

Open
7 tasks
babsdenney opened this issue Oct 16, 2024 · 2 comments
Open
7 tasks

[Development] Align List styles to USWDS #3396

babsdenney opened this issue Oct 16, 2024 · 2 comments
Labels
component-update Change to an existing component platform-design-system-team va-list DS List component

Comments

@babsdenney
Copy link
Contributor

babsdenney commented Oct 16, 2024

Description

The VADS has list styles that don't align with USWDS. We want to align our simple unordered and ordered list with the USWDS.

Details

USWDS List
VADS List
Codepen example of both together
#1362

Tasks

Acceptance Criteria

  • The list above have the same styling as USWDS list
@babsdenney babsdenney added component-update Change to an existing component platform-design-system-team va-list DS List component labels Oct 16, 2024
@caw310
Copy link
Contributor

caw310 commented Oct 16, 2024

@jamigibbs
Copy link
Contributor

The USWDS package for list is usa-list which has the usa-list and usa-list--unstyled classes. But I don't think we want to use those classes directly.

This might be a good example/opportunity for us to try importing those types of base style modules into the CSS Library directly from USWDS mixins. Maybe something like this works?

@import 'uswds-core/src/styles/mixins/typography/usa-list-item';


li {
  @include usa-list;

  li {
    @include usa-list-item;
  }
}

I think this is where our current list style is coming which is just a port of the USWDS v1 list styles from Formation:

https://github.com/department-of-veterans-affairs/component-library/blob/main/packages/css-library/src/stylesheets/formation-overrides/elements/lists.scss#L15-L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-update Change to an existing component platform-design-system-team va-list DS List component
Projects
None yet
Development

No branches or pull requests

3 participants