Skip to content

Commit

Permalink
VACMS-17860: Telephone Migrations Integration (#19225)
Browse files Browse the repository at this point in the history
* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates composer.lock

* VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph (#19234)

* VACMS-17862: Adds configuration changes and script to migrating phones

* VACMS-17862: Updates the phone number audit view

* VACMS-17862: Adds data push changes for mental health

* VACMS-17862: Updates the mental health data push code.

* VACMS-17862: Accounts for no mental health paragraph

* VACMS-17862: Update node and view config

* VACMS-17862: Restores revision_log

* VACMS-17862: Adds step for filling mental health phone

* VACMS-17862: Adds deploy hook and data bypass

* VACMS-17862: Fixes path to script-library

* VACMS-17862: Add help text

* VACMS-17854: Updates composer.lock

* Revert "VACMS-17854: Updates composer.lock"

This reverts commit 4bb3c93.

* Updates the deploy, removing the new one

* VACMS-17860: Removes deploy script for Staff Profile telephone migration (#19308)

* VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command.

---------

Co-authored-by: Christian Burk <[email protected]>

* VACMS-17861: Replace VAMC Billing and Insurance telephone field with telephone paragraph (#19264)

* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates content-hash

* VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type.
- Adds migration to move from old field to new paragraph.

* VACMS-17861: Removed unwanted deploy hook.

* VACMS-17861: Fixing branch rebase issues

* VACMS-17861: Ensures old phone number is no longer displayed.

* VACMS-17861: Hides phone label using existing method.

* VACMS-17861: Resores missing revision_log.

---------

Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Jerry Vrabel <[email protected]>

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

* VACMS-17854: Fix phpstan warnings. (#19362)

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

---------

Co-authored-by: Christian Burk <[email protected]>

* VACMS-17854: Merges main and updates composer lock

* VACMS-17854: Add feature toggle to display old/new telephone fields conditionally (#19472)

* VACMS-17854: Adds telephone migration audit View.

* VACMS-17854: Adds feature toggle for telephone migration.

* VACMS-17854: Show both telephone fields on Staff Profile content type form.

* VACMS-17854: Show both telephone fields on VAMC Facility Billing and Insurance content type form

* VACMS-17854: Show both telephone fields on VAMC Facility content type form.

* VACMS-17854: Put telephone fields behind feature toggle for Staff Profile content type.

* VACMS-17854: Leverage feature toggle to return correct phone for a VAMC Facility in posts into Lighthouse.

* VACMS-17854: Put telephone field behind feature toggle for VAMC System Billing and Insurand and VAMC Facility content types.

* VACMS-17854: Remove test validations introduced in ealier commits. These can be added back after the telephone migration is complete.

* VACMS-18163: Adds new 'How to Apply' field to Benefits taxonomy (#19445)

* VACMS-18163: BenefitTaxonomy four configs for how to apply

* VACMS-18163: Added- revision_log_message to group_va_benefit_workflow

* VACMS-18163: changes to config for field translation

* VACMS-18163: Manual addition of - revision_log_message

* Bump va-gov/content-build from 0.0.3611 to 0.0.3612 (#19487)

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3611 to 0.0.3612.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3611...v0.0.3612)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS-17854: Adds node:view to toggle and accounts for two facility phone fields

* VACMS-17854: Updates config so code can hide fields

* VACMS-17854: Adds check for new facility form

* VACMS-17854: Updates the logic for computers, instead of humans

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: jv-agile6 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Burk <[email protected]>

* VACMS-17854: Fix composer.lock merge conflict resolution mistake by updating content-build to the latest release to match main.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Jerry Vrabel <[email protected]>
Co-authored-by: jv-agile6 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
5 people authored Oct 16, 2024
1 parent ad65266 commit 7515305
Show file tree
Hide file tree
Showing 42 changed files with 4,201 additions and 67 deletions.
4 changes: 2 additions & 2 deletions .ddev/mutagen/mutagen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# and add your own configuration. If you override it you will
# probably want to check it in.
# Please do `ddev mutagen reset` after changing the file.
# See ddev mutagen docs at
# https://ddev.readthedocs.io/en/latest/users/install/performance/
# See DDEV Mutagen docs at
# https://ddev.readthedocs.io/en/stable/users/install/performance/#mutagen
# For detailed information about mutagen configuration options, see
# https://mutagen.io/documentation/introduction/configuration
sync:
Expand Down
107 changes: 107 additions & 0 deletions .ddev/nginx_full/nginx-site.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
# ddev drupal10 config

# If you want to take over this file and customize it, remove the line above
# and ddev will respect it and won't overwrite the file.
# See https://ddev.readthedocs.io/en/stable/users/extend/customization-extendibility/#custom-nginx-configuration

server {
listen 80 default_server;
listen 443 ssl default_server;

root /var/www/html/docroot;

ssl_certificate /etc/ssl/certs/master.crt;
ssl_certificate_key /etc/ssl/certs/master.key;

include /etc/nginx/monitoring.conf;

index index.php index.htm index.html;

# Disable sendfile as per https://docs.vagrantup.com/v2/synced-folders/virtualbox.html
sendfile off;
error_log /dev/stdout info;
access_log /var/log/nginx/access.log;

location / {
absolute_redirect off;
try_files $uri $uri/ /index.php?$query_string; # For Drupal >= 7
}

location @rewrite {
# For D7 and above:
# Clean URLs are handled in drupal_environment_initialize().
rewrite ^ /index.php;
}

# Handle image styles for Drupal 7+
location ~ ^/sites/.*/files/styles/ {
try_files $uri @rewrite;
}

# pass the PHP scripts to FastCGI server listening on socket
location ~ '\.php$|^/update.php' {
fastcgi_split_path_info ^(.+\.php)(/.+)$;
fastcgi_pass unix:/run/php-fpm.sock;

fastcgi_buffers 256 256k;
fastcgi_buffer_size 256k;
client_max_body_size 50M;
proxy_buffer_size 256k;
proxy_buffers 4 256k;
proxy_busy_buffers_size 256k;

fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
fastcgi_param SCRIPT_NAME $fastcgi_script_name;
fastcgi_index index.php;
include fastcgi_params;
fastcgi_intercept_errors off;
# fastcgi_read_timeout should match max_execution_time in php.ini
fastcgi_read_timeout 10m;
fastcgi_param SERVER_NAME $host;
fastcgi_param HTTPS $fcgi_https;
}

# Expire rules for static content

# Prevent clients from accessing hidden files (starting with a dot)
# This is particularly important if you store .htpasswd files in the site hierarchy
# Access to `/.well-known/` is allowed.
# https://www.mnot.net/blog/2010/04/07/well-known
# https://tools.ietf.org/html/rfc5785
location ~* /\.(?!well-known\/) {
deny all;
}

# Prevent clients from accessing to backup/config/source files
location ~* (?:\.(?:bak|conf|dist|fla|in[ci]|log|psd|sh|sql|sw[op])|~)$ {
deny all;
}

## Regular private file serving (i.e. handled by Drupal).
location ^~ /system/files/ {
## For not signaling a 404 in the error log whenever the
## system/files directory is accessed add the line below.
## Note that the 404 is the intended behavior.
log_not_found off;
access_log off;
expires 30d;
try_files $uri @rewrite;
}

# Media: images, icons, video, audio, HTC
location ~* \.(jpg|jpeg|gif|png|ico|cur|gz|svg|svgz|mp4|ogg|ogv|webm|webp|htc)$ {
try_files $uri @rewrite;
expires max;
log_not_found off;
}

# js and css always loaded
location ~* \.(js|css)$ {
try_files $uri @rewrite;
expires -1;
log_not_found off;
}

include /etc/nginx/common.d/*.conf;
include /mnt/ddev_config/nginx/*.conf;
}
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
/docroot/modules/custom/va_gov_api @department-of-veterans-affairs/accelerated-publishing
/docroot/modules/custom/va_gov_backend # @department-of-veterans-affairs/platform-cms-drupal-engineers
/docroot/modules/custom/va_gov_banner @department-of-veterans-affairs/public-websites-cms
/docroot/modules/custom/va_gov_batch @department-of-veterans-affairs/public-websites-cms
/docroot/modules/custom/va_gov_benefits @department-of-veterans-affairs/public-websites-cms
/docroot/modules/custom/va_gov_block_types @department-of-veterans-affairs/public-websites-cms
/docroot/modules/custom/va_gov_build_trigger # @department-of-veterans-affairs/platform-cms-drupal-engineers
Expand Down
2 changes: 2 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"drupal/ckeditor_abbreviation": "^4.0@alpha",
"drupal/clientside_validation": "^4.0",
"drupal/coder": "^8.3",
"drupal/codit_batch_operations": "^1.0",
"drupal/codit_menu_tools": "^1.0@alpha",
"drupal/components": "^3.0@beta",
"drupal/computed_breadcrumbs": "^1.1",
Expand Down Expand Up @@ -202,6 +203,7 @@
"drush/drush": "12.4.3",
"easyrdf/easyrdf": "1.1.1 as 0.9.1",
"geocoder-php/mapbox-provider": "^1.3",
"giggsey/libphonenumber-for-php": "^8.13",
"gitonomy/gitlib": "^1.2",
"http-interop/http-factory-guzzle": "^1.0",
"knplabs/github-api": "^3.0",
Expand Down
191 changes: 190 additions & 1 deletion composer.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "f9050af45d3b7f966ae2040c97fdb70d",
"content-hash": "ec08348fac4ca68b02c83aabc2bba495",
"packages": [
{
"name": "asm89/stack-cors",
Expand Down Expand Up @@ -3332,6 +3332,66 @@
},
"time": "2024-04-21T06:13:24+00:00"
},
{
"name": "drupal/codit_batch_operations",
"version": "1.0.2",
"source": {
"type": "git",
"url": "https://git.drupalcode.org/project/codit_batch_operations.git",
"reference": "1.0.2"
},
"dist": {
"type": "zip",
"url": "https://ftp.drupal.org/files/projects/codit_batch_operations-1.0.2.zip",
"reference": "1.0.2",
"shasum": "1210c2527d77f8a5d2993772f801d29bcd911bc2"
},
"require": {
"drupal/core": "^10 || ^11"
},
"conflict": {
"drush/drush": "<9.0"
},
"type": "drupal-module",
"extra": {
"drupal": {
"version": "1.0.2",
"datestamp": "1723428187",
"security-coverage": {
"status": "covered",
"message": "Covered by Drupal's security advisory policy"
}
},
"drush": {
"services": {
"drush.services.yml": "<11.0"
}
}
},
"notification-url": "https://packages.drupal.org/8/downloads",
"license": [
"GPL-2.0+"
],
"authors": [
{
"name": "skyriter",
"homepage": "https://www.drupal.org/user/1703682"
},
{
"name": "swirt",
"homepage": "https://www.drupal.org/user/138230"
}
],
"description": "Provides methods and framework for running batch operations.",
"homepage": "https://www.drupal.org/project/codit_batch_operations",
"keywords": [
"Drupal"
],
"support": {
"source": "http://cgit.drupalcode.org/codit_batch_operations",
"issues": "http://drupal.org/project/issues/codit_batch_operations"
}
},
{
"name": "drupal/codit_menu_tools",
"version": "1.0.3",
Expand Down Expand Up @@ -15548,6 +15608,135 @@
],
"time": "2023-11-06T15:42:03+00:00"
},
{
"name": "giggsey/libphonenumber-for-php",
"version": "8.13.43",
"source": {
"type": "git",
"url": "https://github.com/giggsey/libphonenumber-for-php.git",
"reference": "62250ef492ea8afedf534381844194f43ff1f7f2"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/giggsey/libphonenumber-for-php/zipball/62250ef492ea8afedf534381844194f43ff1f7f2",
"reference": "62250ef492ea8afedf534381844194f43ff1f7f2",
"shasum": ""
},
"require": {
"giggsey/locale": "^1.7|^2.0",
"php": ">=5.3.2",
"symfony/polyfill-mbstring": "^1.17"
},
"replace": {
"giggsey/libphonenumber-for-php-lite": "self.version"
},
"require-dev": {
"pear/pear-core-minimal": "^1.9",
"pear/pear_exception": "^1.0",
"pear/versioncontrol_git": "^0.5",
"phing/phing": "^2.7",
"php-coveralls/php-coveralls": "^1.0|^2.0",
"symfony/console": "^2.8|^3.0|^v4.4|^v5.2",
"symfony/phpunit-bridge": "^4.2 || ^5"
},
"type": "library",
"extra": {
"branch-alias": {
"dev-master": "8.x-dev"
}
},
"autoload": {
"psr-4": {
"libphonenumber\\": "src/"
},
"exclude-from-classmap": [
"/src/data/",
"/src/carrier/data/",
"/src/geocoding/data/",
"/src/timezone/data/"
]
},
"notification-url": "https://packagist.org/downloads/",
"license": [
"Apache-2.0"
],
"authors": [
{
"name": "Joshua Gigg",
"email": "[email protected]",
"homepage": "https://giggsey.com/"
}
],
"description": "PHP Port of Google's libphonenumber",
"homepage": "https://github.com/giggsey/libphonenumber-for-php",
"keywords": [
"geocoding",
"geolocation",
"libphonenumber",
"mobile",
"phonenumber",
"validation"
],
"support": {
"issues": "https://github.com/giggsey/libphonenumber-for-php/issues",
"source": "https://github.com/giggsey/libphonenumber-for-php"
},
"time": "2024-08-13T12:17:37+00:00"
},
{
"name": "giggsey/locale",
"version": "2.6",
"source": {
"type": "git",
"url": "https://github.com/giggsey/Locale.git",
"reference": "37874fa473131247c348059fb7b8985efc18b5ea"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/giggsey/Locale/zipball/37874fa473131247c348059fb7b8985efc18b5ea",
"reference": "37874fa473131247c348059fb7b8985efc18b5ea",
"shasum": ""
},
"require": {
"php": ">=7.2"
},
"require-dev": {
"ext-json": "*",
"pear/pear-core-minimal": "^1.9",
"pear/pear_exception": "^1.0",
"pear/versioncontrol_git": "^0.5",
"phing/phing": "^2.7",
"php-coveralls/php-coveralls": "^2.0",
"phpunit/phpunit": "^8.5|^9.5",
"symfony/console": "^5.0|^6.0",
"symfony/filesystem": "^5.0|^6.0",
"symfony/finder": "^5.0|^6.0",
"symfony/process": "^5.0|^6.0"
},
"type": "library",
"autoload": {
"psr-4": {
"Giggsey\\Locale\\": "src/"
}
},
"notification-url": "https://packagist.org/downloads/",
"license": [
"MIT"
],
"authors": [
{
"name": "Joshua Gigg",
"email": "[email protected]",
"homepage": "https://giggsey.com/"
}
],
"description": "Locale functions required by libphonenumber-for-php",
"support": {
"issues": "https://github.com/giggsey/Locale/issues",
"source": "https://github.com/giggsey/Locale/tree/2.6"
},
"time": "2024-04-18T19:31:19+00:00"
},
{
"name": "gitonomy/gitlib",
"version": "v1.4.0",
Expand Down
3 changes: 3 additions & 0 deletions config/sync/codit_batch_operations.settings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
script_location: va_gov_batch
default_user: '1317'
cron_enabled: 0
Loading

0 comments on commit 7515305

Please sign in to comment.