Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <dialog> element #60

Open
medienbaecker opened this issue Jul 8, 2024 · 1 comment · May be fixed by #61
Open

Use <dialog> element #60

medienbaecker opened this issue Jul 8, 2024 · 1 comment · May be fixed by #61
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@medienbaecker
Copy link

I finally had the chance to test Parvus today, and I love it — finally an accessible lightbox!

What do you think about using the dialog element instead of a z-index of 1337? :)
Also: automatic ARIA role, focus management, keyboard navigation — I think it would be a great fit.

@deoostfrees deoostfrees added the type: enhancement New feature or request label Jul 9, 2024
@deoostfrees deoostfrees added this to the 3.0.0 milestone Jul 9, 2024
@deoostfrees
Copy link
Owner

Moin @medienbaecker 👋,

the native dialog element has also been on my list for some time. I think it's best to implement it with the next major release (3.0.0), which I plan to start next weekend.

@deoostfrees deoostfrees linked a pull request Jul 9, 2024 that will close this issue
@deoostfrees deoostfrees self-assigned this Jul 9, 2024
deoostfrees added a commit that referenced this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants