Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing await in ga middleware #124

Open
Ko1103 opened this issue Apr 5, 2023 · 2 comments
Open

Missing await in ga middleware #124

Ko1103 opened this issue Apr 5, 2023 · 2 comments

Comments

@Ko1103
Copy link

Ko1103 commented Apr 5, 2023

I'm using this deno_blog with ga middleware, but Google Analytics not working.
I think I found the cause, it is missing await in this line.

gaReporter(request, ctx.connInfo, res!, start, err);

Reproduce

Here's my main.ts file.

import blog, { ga, redirects } from "blog";

blog({
   ...
  middlewares: [
    // If you want to set up Google Analytics, paste your GA key here.
    ga("G-XXXXXXXXXX"),
  ],
});
Ko1103 added a commit to Ko1103/deno_blog that referenced this issue Apr 5, 2023
@rojvv
Copy link
Contributor

rojvv commented Apr 5, 2023

How do you know if it is not working?

@Ko1103
Copy link
Author

Ko1103 commented Apr 7, 2023

@roj1512 Sorry, I totally misunderstood about Server Side GA tag, I've not finished setup yet. So this is my problem.
Sorry again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants