Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compression on text/event-stream #27725

Open
nickchomey opened this issue Jan 18, 2025 · 3 comments · May be fixed by #27776
Open

Support compression on text/event-stream #27725

nickchomey opened this issue Jan 18, 2025 · 3 comments · May be fixed by #27776
Labels
help wanted community help requested serve suggestion suggestions for new features (yet to be agreed)

Comments

@nickchomey
Copy link

Currently Deno compresses responses based on this database of content types. It doesn't include text/event-stream, which is very commonly used for Server-Sent Events (which is really just a normal http response with text/string content of a specific format).

Ive successfully compressed event-stream responses with Caddy with its normal compression encoding directive. Nothing fancy needs to happen to make this work.

It would be great if Deno could support this as well, so that we don't need to implement it in the application or use a proxy like Caddy.

@bartlomieju bartlomieju added suggestion suggestions for new features (yet to be agreed) help wanted community help requested serve labels Jan 20, 2025
@aaron-ang
Copy link
Contributor

aaron-ang commented Jan 22, 2025

hi, I'd like to work on this

@aaron-ang
Copy link
Contributor

After reviewing the repo, I will need to add the text/event-stream option in ext/http/compressible.rs. Is there anything else to consider other than this trivial fix?

@aaron-ang
Copy link
Contributor

related #22562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted community help requested serve suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants