Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile failure with go 1.13 #48

Open
torbenschinke opened this issue Sep 13, 2019 · 2 comments
Open

compile failure with go 1.13 #48

torbenschinke opened this issue Sep 13, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@torbenschinke
Copy link

If compiling with Go 1.13, a compiling error comes up:

github.com/dennwc/dom/js

../../../../go/pkg/mod/github.com/dennwc/[email protected]/js/bytes.go:20:2: undefined: js.TypedArray
../../../../go/pkg/mod/github.com/dennwc/[email protected]/js/bytes.go:30:7: undefined: js.TypedArrayOf

The change log (https://golang.org/doc/go1.13#syscall/js) states that the types have been changed: "TypedArrayOf has been replaced by CopyBytesToGo and CopyBytesToJS for copying bytes between a byte slice and a Uint8Array."
@dennwc dennwc added the bug Something isn't working label Sep 13, 2019
@dennwc
Copy link
Owner

dennwc commented Sep 13, 2019

Yes, the library doesn't support Go 1.13 yet.

@zorchenhimer zorchenhimer mentioned this issue Sep 19, 2019
Closed
noartem added a commit to gascore/dom that referenced this issue Oct 23, 2019
@noartem
Fixed dennwc#48
8de3c9a
tangsy998 pushed a commit to tangsy998/dom that referenced this issue Jan 24, 2020
@tangfeixiong
resolve compile failure with go1.13: dennwc#48
2a6c6ff
@maitredede
Copy link

golang 1.14 seams worse 😄

itskass added a commit to itskass/dom that referenced this issue Apr 10, 2020
@itskass
updated for go1.13
1409183 
dennwc#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dennwc @maitredede @torbenschinke