Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Wasm binary hashing mechanism #385

Open
2 tasks
lastmjs opened this issue May 13, 2023 · 1 comment
Open
2 tasks

Create new Wasm binary hashing mechanism #385

lastmjs opened this issue May 13, 2023 · 1 comment
Labels
new feature Adds additional functionality

Comments

@lastmjs
Copy link
Member

lastmjs commented May 13, 2023

Because of dynamic module loading, binary hash checking of Kybra canisters won't give the same benefits or guarantess as Rust/Motoko/Azle binary hashes. We'll need to come up with mechanisms to fix this.

  • Keep in mind that with Kybra, the binary hash will basically be useless, as much of the actual code/functionality will change and not be in the binary. Perhaps we could send the Python source code up in the binary to help with this?
  • We could probably hash all source code and include the hash in the binary though
@dansteren dansteren added the new feature Adds additional functionality label Jul 26, 2023
@lastmjs
Copy link
Member Author

lastmjs commented Apr 2, 2024

This shouldn't be a problem anymore, except for the python stdlib. Only on first deploy will the stdlib be a part of the binary, so the hash will change on subsequent deploys. This is a much simpler problem now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Adds additional functionality
Projects
None yet
Development

No branches or pull requests

2 participants