Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back swipe doesn't work in xdc apps #2317

Open
Amzd opened this issue Oct 14, 2024 · 6 comments
Open

Back swipe doesn't work in xdc apps #2317

Amzd opened this issue Oct 14, 2024 · 6 comments

Comments

@Amzd
Copy link
Collaborator

Amzd commented Oct 14, 2024

  • iOS version: iOS 16
  • Device: iPhone X
  • Delta Chat version:
  • Expected behavior: swipe from left edge should close pushed vc
  • Actual behavior: doesn't do anything, probably because it's a web view and the back swipe is reserved to go back in history?
  • Steps to reproduce the problem: open any xdc app and try to close it with a swipe
  • Screenshots:
  • Logs:
@Amzd Amzd added the bug label Oct 14, 2024
@r10s
Copy link
Member

r10s commented Oct 14, 2024

this is on purpose as apps, esp games, using comparable gestures are otherwise terminated unexpectedly - which is much worse, when a new highscore is ruined by that :)

@r10s r10s removed the bug label Oct 14, 2024
@Amzd
Copy link
Collaborator Author

Amzd commented Oct 15, 2024

I see. That would be annoying. Still think it's also annoying that you can't swipe back when you go into eg a todo list. Maybe we can make a toggle for it that remembers which app you want to be able to swipe back?

@r10s
Copy link
Member

r10s commented Oct 15, 2024

maybe. issue with an option will then be that there is no consistent way to exit apps :/ that will look even more as bug - or needs explanation/care of users. also, we try to avoid options wherever possible.

maybe we should also consider to re-add the swipe option in general. this might be the better tradeoff:

  • since it was removed, screens got bigger (esp. we devs has an iPhone SE1 that time)
  • the decision that time was easy, as there were no tools at all. @adbenitez can you say what is the worse/fastest game to try that may interfere with swipe to go back? (@adbenitez did quite some of the existing games)
  • in general iOS is pretty good at detecting these swipes, one has really to start outside the screen - and there are anyway swipes from top/bottom we cannot disable

@Amzd
Copy link
Collaborator Author

Amzd commented Oct 15, 2024

Idk how fast the games are but we can also store the pushed webxdc vc for a couple seconds so if you click the same webxdc item, it will give the stored vc instead of restarting the web view? So if you accidentally exit it wouldn't discard anything.

or on first back-swipe we can ask the user "did you mean to close the webxdc app? y/n" and store their preference for this webxdc app

It's not great UX to have to go all the way to top left to exit the view.

@Simon-Laux
Copy link
Member

I guess if the webxdc app should configure it, then it should be a property in the webxdc manifest.toml

@Amzd
Copy link
Collaborator Author

Amzd commented Oct 15, 2024

#2322 made a concept that fixes some of your concerns with backswipe interfering with games.

RPReplay_Final1729015044.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants