Sync back the change of #603 and #604 to branch-1.2 to make 1.2 work with Spark 4.0 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeltaSharingLimitPushDown uses the pattern with LogicalRelation which could change, in terms of parameter in constructor. Spark community made a change in upcoming Spark 4.0 (apache/spark#48676) to add a new parameter in LogicalRelation, and the change will break the pattern.
Since the pattern only picks up the relation from LogicalRelation, the pattern object Spark community introduced along with the above change (apache/spark#48605) would be helpful to not encounter the issue in upcoming Spark 4.0 when Delta Sharing supports the version.
This PR introduces a shim to address the new parameter in LogicalRelation in Spark 4.0.
Since Delta Sharing does not perform cross compilation for Spark version and Spark 4.0 is expected to be released in early next year, this PR would help to defer the effort of cross compilation with multiple artifacts till really needed.