Feature fix load as spark #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue for when initiating load_as_spark() in case when a spark session is already initiated in separate thread and cannot be started in current thread. This usually arises when using the method in django rest api.
This reverts commit 22f3124.
Fixed issue for when initiating load_as_spark() in case when a spark session is already initiated in separate thread and cannot be started in current thread. This usually arises when using the method in Django rest api.
linzhou-db
reviewed
Jun 26, 2024
| @@ -150,11 +150,7 @@ def load_as_spark( | |||
| except ImportError: | |||
| raise ImportError("Unable to import pyspark. `load_as_spark` requires PySpark.") | |||
|
|
|||
| spark = SparkSession.getActiveSession() | |||
| assert spark is not None, ( | |||
There was a problem hiding this comment.
do we still want to keep the assert?
There was a problem hiding this comment.
It will not be beneficial to keep it. If any case occurs with issues in spark session fetching then this assert will handle that.
There was a problem hiding this comment.
I want to hear your thoughts as to what should be the better approach.
There was a problem hiding this comment.
Sorry for the delay, I'm reading this, it seems it will default to None, so I think this assert is still helpful. https://spark.apache.org/docs/latest/api/java/org/apache/spark/sql/SparkSession.html
|
feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #508
Used SparkSession.active() instead of SparkSession.getActiveSession() in Delta-Sharing.py which returns a spark session regardless of any active session being present or not.