Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up ffi/src/engine_data.rs #538

Open
zachschuermann opened this issue Nov 25, 2024 · 0 comments
Open

clean up ffi/src/engine_data.rs #538

zachschuermann opened this issue Nov 25, 2024 · 0 comments

Comments

@zachschuermann
Copy link
Collaborator

some vestiges of old implementations have been moved to this module, and it's generally covered with TODO's. we should revisit it.

copied comment from @scovich regarding engine_data_length:

This is a somewhat odd API... presumably engine provided this engine data instance to kernel in the first place, so presumably engine should already know how to get the length if it wants it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachschuermann