Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file listing should handle incomplete multi-part checkpoints #497

Open
OussamaSaoudi-db opened this issue Nov 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@OussamaSaoudi-db
Copy link
Collaborator

Describe the bug

When constructing a LogSegment, we scan the _delta_log directory for checkpoints and commits. The most recent checkpoint is collected from the log, but the kernel does not check that it has collected a full multi-part checkpoint. Thus, the checkpoint returned may be incomplete.

To Reproduce

This behaviour can be seen in the LogSegment test build_snapshot_with_missing_checkpoint_part_no_hint.

Expected behavior

build_snapshot_with_missing_checkpoint_part_no_hint should pass and return the most recent complete checkpoint at version 3.

Additional context

No response

@OussamaSaoudi-db OussamaSaoudi-db added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant