Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image needs 'General' property section and most others #64

Open
MattRudy opened this issue Apr 26, 2021 · 5 comments · May be fixed by #65
Open

Image needs 'General' property section and most others #64

MattRudy opened this issue Apr 26, 2021 · 5 comments · May be fixed by #65

Comments

@MattRudy
Copy link
Contributor

No description provided.

@MikeCarlo
Copy link
Contributor

My recommendation would to not make issues for all of these, however instead pull a branch and make the appropriate changes and then ask for a pull request to submit your changes.

Making many many comments without contributing what you know is not extremely helpful.

@MikeCarlo
Copy link
Contributor

I'd also recommend using this tool to get the general properties as there is only really one general property. https://themes.powerbi.tips/properties

@MattRudy
Copy link
Contributor Author

I agree Mike - I've been working to keep this repo updated and as I was going through templates I didn't realize just how many needed that added, I expected to create maybe 3-4 issues and not closer to 15.

I'm actively working on a fork to close these! But I figured I'd make the issues in case anyone else wanted to jump on some of them.

@MikeCarlo
Copy link
Contributor

gotcha, thanks.

@MattRudy
Copy link
Contributor Author

MattRudy commented Apr 29, 2021

Also, love your site - I've used that tool before! I'll reach out to you separately with some questions about future features for the theme generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants