Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centering in Markdown is broken and different from before rework #2484

Open
jesseb34r opened this issue Dec 17, 2024 · 3 comments · Fixed by #2509
Open

Centering in Markdown is broken and different from before rework #2484

jesseb34r opened this issue Dec 17, 2024 · 3 comments · Fixed by #2509

Comments

@jesseb34r
Copy link
Contributor

jesseb34r commented Dec 17, 2024

To my understanding, before the migration to tailwind centered text was generated using the centered-markdown className applied here. This class no longer has an associated style loaded so the centering isn't happening.

I think people are also saying that all headings were centered previously. I do not know if we want this, markdown classically does not center headings by default.

The simple fix for this is probably to apply the text-align tailwind class instead of the deprecated centered-markdown. And then if users want their headings centered they can use the >>> syntax.

relevant discord thread

@lunakv
Copy link
Contributor

lunakv commented Dec 18, 2024

I think people are also saying that all headings were centered previously.

Definitely not true, headings have always been left-justified by default, just as any other text.

@lunakv
Copy link
Contributor

lunakv commented Dec 18, 2024

This seems like a pretty simple fix, but just in case it requires any non-trivial involvement with the Markdown parser code, I tried to document that part pretty extensively (and I'm always available for consult if something is unclear).

@KaelenProctor
Copy link
Contributor

@jesseb34r Fixes for centering have been deployed, can you validate whether or not the centering is working again for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants