Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if number of images in the folder is < photosPageSize #62

Open
zsavicreative opened this issue Jul 17, 2017 · 0 comments
Open

if number of images in the folder is < photosPageSize #62

zsavicreative opened this issue Jul 17, 2017 · 0 comments

Comments

@zsavicreative
Copy link

zsavicreative commented Jul 17, 2017

the is more of a request then an issue.. This plugin is absolutely amazing. and kudos to your coding skills. Thanks a bunch for this.

it causes the "more photos" button to still appear and doesn't get removed even after click.

the situation being single page displaying multiple albums using the same FacebookAlbumBrowser function. So when using a specific number for photosPageSize which is ideal for a larger quantity album creates this unhandled scenario with displaying 'more photos' button even if there are no more photos to show.

I tried to make changes to jquery.fb.albumbrowser.js but I've had no luck with adding a if statement to check if all images are being displayed to hide more photos button.

Also in my scenario I've created a structure where by each album requested on the page has its own 'more photos' button.

If you have issues recreating the scenario I'll be happy to show you what I'm talking about... I tried to recreate it in code pen but was unable due to only having access to one dom instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant