Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether clustersCheckinsTable can use a *Timestamp #118

Open
arschles opened this issue May 5, 2016 · 3 comments
Open

Investigate whether clustersCheckinsTable can use a *Timestamp #118

arschles opened this issue May 5, 2016 · 3 comments
Labels
bug refactor

Comments

@arschles
Copy link
Member

arschles commented May 5, 2016

it's currently using a string because at the time, it looked like gorm couldn't handle (database/sql/driver).Valuers. I've found, in #105, that it can, however. Investigate whether it can use a *Timestamp instead (which itself is a Valuer)
@arschles arschles self-assigned this May 5, 2016
@arschles arschles added the bug label May 5, 2016
@arschles arschles added this to the v2.0-beta4 milestone May 5, 2016
@arschles arschles removed their assignment May 5, 2016
@arschles
Copy link
Member Author

arschles commented May 9, 2016

In #123 (specifically ee4613e), the versionsTable uses a Timestamp (no pointer), so this should be possible

@arschles
Copy link
Member Author

arschles commented May 9, 2016

I'm moving this to RC1

@arschles arschles modified the milestones: v2.0-rc1, v2.0-beta4 May 9, 2016
@arschles arschles modified the milestone: v2.0-rc1 May 19, 2016
@mboersma
Copy link
Member

@arschles have we implemented the pointer change described here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arschles @mboersma