Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common Jenkinsfile logic into Pipeline Global Library #142

Open
vdice opened this issue Jul 20, 2016 · 3 comments
Open

Extract common Jenkinsfile logic into Pipeline Global Library #142

vdice opened this issue Jul 20, 2016 · 3 comments

Comments

@vdice
Copy link
Member

vdice commented Jul 20, 2016

This repo's Jenkinsfile as well as the controller-sdk-go repo's Jenkinsfile share common logic, especially as of deis/controller-sdk-go#46 which builds workflow-cli in place, duplicating many steps used in this repo's pipeline.

It would be preferable if we extracted shared logic into common functionality via the Pipeline Global Library to both reduce duplication and enable only making changes to such functionality in one location. Some functionality will even prove to be generally useful outside of workflow-cli/controller-sdk-go's scope, such as sending email notifications on e2e failures.

@vdice
Copy link
Member Author

vdice commented Oct 3, 2016

A first attempt at following the resources mentioned in the description didn't pan out very well, but it looks like there has been more activity on https://issues.jenkins-ci.org/browse/JENKINS-31155 which might be useful when this is pulled in.

@mboersma
Copy link
Member

Also there's https://github.com/jenkinsci/workflow-remote-loader-plugin which might help.

@Cryptophobia
Copy link

This issue was moved to teamhephy/workflow-cli#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants