Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claiming a reserved name for the router #334

Open
pixeleet opened this issue Apr 4, 2017 · 3 comments
Open

Claiming a reserved name for the router #334

pixeleet opened this issue Apr 4, 2017 · 3 comments

Comments

@pixeleet
Copy link
Contributor

pixeleet commented Apr 4, 2017

router. (or maybe deis-router.) becoming the router's official address, much as deis.<domain is the address of the controller and deis-builder. is the address of the builder. We'd have to add router (or deis-router) to the list of reserved names in the controller.

@krancour
Copy link
Contributor

krancour commented Apr 4, 2017

As noted in the thread this convo forked from (#333), this is really a formality of sorts, since any address that resolves to the router but doesn't match any routable application will already get you to the router's default vhost. Nevertheless, I think I am in favor of this, because it's easier and more succinct to write router.<domain> (e.g. in documentation) than to write "any address that resolves to the router but doesn't match any routable application". Big 👍 on this, unless @mboersma is opposed for any reason.

@krancour
Copy link
Contributor

krancour commented Apr 4, 2017

@pixeleet can I assume you're also willing to PR this?

@Cryptophobia
Copy link

This issue was moved to teamhephy/router#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants