Komoju Woocommerce settings tab throws error

[kylebarrow]

Wordpress version: 6.0
Woocommerce version: 6.5.1
KOMOJU Payments version: 2.2.0

Issue: Opening the Komoju tab in Woocommerce settings throws an fatal error so setting are unable to be viewed or modified.
Steps to reproduce:

1. As an Wordpress administration, open Woocomerce setting.
2. Go to the Komoju tab.
3. Expected behaviour: access to a Komoju settings to view or modify.
4. Actual behaviour: the settings screen shows a fatal error and settings cannot be viewed or modified:
   2022-06-10T01:55:07+00:00 CRITICAL Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, string given in /REDACTED/wp-content/plugins/komoju-japanese-payments/class-wc-settings-page-komoju.php:97 Stack trace: #0 /REDACTED/wp-content/plugins/komoju-japanese-payments/class-wc-settings-page-komoju.php(97): in_array('konbini', '') #1 /REDACTED/wp-includes/class-wp-hook.php(307): WC_Settings_Page_Komoju->output_payment_methods(Array) #2 /REDACTED/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters('', Array) #3 /REDACTED/wp-includes/plugin.php(476): WP_Hook->do_action(Array) #4 /REDACTED/wp-content/plugins/woocommerce/includes/admin/class-wc-admin-settings.php(729): do_action('woocommerce_adm...', Array) #5 /REDACTED/wp-content/plugins/woocommerce/includes/admin/settings/class-wc-settings-page.php(213): WC_Admin_Settings::output_fields(Array) #6 /REDACTED/wp-includes/class-wp-hook.php(307): WC_Settings_Page->output('') #7 /REDACTED/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters('', Array) #8 /REDACTED/wp-includes/plugin.php(476): WP_Hook->do_action(Array) #9 /REDACTED/wp-content/plugins/woocommerce/includes/admin/views/html-admin-settings.php(40): do_action('woocommerce_set...') #10 /REDACTED/wp-content/plugins/woocommerce/includes/admin/class-wc-admin-settings.php(154): include('/REDACTED...') #11 /REDACTED/wp-content/plugins/woocommerce/includes/admin/class-wc-admin-menus.php(280): WC_Admin_Settings::output() #12 /REDACTED/wp-includes/class-wp-hook.php(307): WC_Admin_Menus->settings_page('') #13 /REDACTED/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters('', Array) #14 /REDACTED/wp-includes/plugin.php(476): WP_Hook->do_action(Array) #15 /REDACTED/wp-admin/admin.php(259): do_action('woocommerce_pag...') #16 {main} thrown in /REDACTED/wp-content/plugins/komoju-japanese-payments/class-wc-settings-page-komoju.php on line 97

[Resonious]

Thanks for the detailed report.

A fix for this has been published - can you try again with the latest version? (2.2.5)

[kylebarrow]

Hi Nigel, We have updated on our testing platform and are no longer seeing the error, thanks. Not sure this is another issue but the payment gateway checkboxes in Komoju settings do not appear to do anything, for example, I checked and saved the コンビニ payment gateway: But on checkout, all payment gateways are exposed (default Storefront theme): Is this expected behaviour? Cheers Kyle

…

On Jun 16, 2022, at 17:14, Nigel Baillie ***@***.***> wrote: Thanks for the detailed report. A fix for this has been published - can you try again with the latest version? (2.2.5) — Reply to this email directly, view it on GitHub <#58 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD6TYGKUFTJUC3ZDGZMLD3VPLO7LANCNFSM5YMDQD7A>. You are receiving this because you authored the thread.

[Resonious]

Hey @kylebarrow

Sorry for the delay in getting back. If you go to the "Payments" tab in your WooCommerce settings, are you using the gateway called "Komoju", or are you using "Komoju - Konbini"?

The checkboxes in Komoju settings just generate new gateways for your "Payments" settings - they have no effect on which payment methods show up under the "Komoju" gateway.