You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off - is there any reason behind removing/restoring minimap when Zen is toggled (unless minimap option is checked) that I'm overseeing? I think it would make perfect sense to do it with plain CSS in combination with data-attribute (something like data-zen-minimap="true||false").
The reason for proposed change is that currently I sometimes get multiple minimaps restored, instead of the only one that was removed in the first place. I don't really know exactly when it occurs, but from what I encountered, it seems that quickly toggling Zen on and off causes the issue (which does make sense). Whenever it happens I need to restart Atom completely, as just refreshing it doesn't help.
If you're up for a change, I can submit PR fixing the issue as proposed above.
The text was updated successfully, but these errors were encountered:
If there is a bug with minimap toggling I'll accept a PR (the code does look a bit wonky, not sure if that's still compatible), but I'm not experiencing any issues and I don't really have the time to try and find out if there is anything wrong. It's been a while of course (sorry about that) but if anyone wants to review this and submit a fix I'll pull it.
First off - is there any reason behind removing/restoring minimap when Zen is toggled (unless minimap option is checked) that I'm overseeing? I think it would make perfect sense to do it with plain CSS in combination with data-attribute (something like
data-zen-minimap="true||false"
).The reason for proposed change is that currently I sometimes get multiple minimaps restored, instead of the only one that was removed in the first place. I don't really know exactly when it occurs, but from what I encountered, it seems that quickly toggling Zen on and off causes the issue (which does make sense). Whenever it happens I need to restart Atom completely, as just refreshing it doesn't help.
If you're up for a change, I can submit PR fixing the issue as proposed above.
The text was updated successfully, but these errors were encountered: