Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring minimap #93

Open
markoradak opened this issue Apr 11, 2016 · 1 comment
Open

Restoring minimap #93

markoradak opened this issue Apr 11, 2016 · 1 comment

Comments

@markoradak
Copy link

First off - is there any reason behind removing/restoring minimap when Zen is toggled (unless minimap option is checked) that I'm overseeing? I think it would make perfect sense to do it with plain CSS in combination with data-attribute (something like data-zen-minimap="true||false").

The reason for proposed change is that currently I sometimes get multiple minimaps restored, instead of the only one that was removed in the first place. I don't really know exactly when it occurs, but from what I encountered, it seems that quickly toggling Zen on and off causes the issue (which does make sense). Whenever it happens I need to restart Atom completely, as just refreshing it doesn't help.

If you're up for a change, I can submit PR fixing the issue as proposed above.

@braver
Copy link
Collaborator

braver commented May 19, 2017

If there is a bug with minimap toggling I'll accept a PR (the code does look a bit wonky, not sure if that's still compatible), but I'm not experiencing any issues and I don't really have the time to try and find out if there is anything wrong. It's been a while of course (sorry about that) but if anyone wants to review this and submit a fix I'll pull it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants