Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup source behind the quote #64

Open
mnunemacher-dm opened this issue Feb 7, 2020 · 3 comments
Open

Lookup source behind the quote #64

mnunemacher-dm opened this issue Feb 7, 2020 · 3 comments

Comments

@mnunemacher-dm
Copy link
Contributor

It would be nice to be able to get more information/reasoning behind the quote suggesting why a word/phrase should not be used. Since each quote has a source url behind the scenes, maybe the block displaying the quote to the user can hyperlink to that source url.

@ProfJanetDavis
Copy link
Contributor

I like this idea a lot. It could be quite motivational to read the article the quote comes from.

@sbrudz
Copy link
Contributor

sbrudz commented Feb 10, 2020

I agree. This could build upon the work that @steveatdm did in the usability styling branch to change the tooltip into a real floating overlay. @steveatdm would it be possible to modify your implementation so that it doesn't use jQuery? Early on, just-not-sorry used jQuery, but we hit issues with our version of jQuery conflicting with the version of jQuery loaded by other extensions and causing them to break, so we removed it.

@steveatdm
Copy link
Contributor

@sbrudz Yes, this was one of the next issues to tackle on the priority list. Want to remove that as a dependency and scope down the mouse move detection from the whole document to the target div (and probably some other minor refactoring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants