Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and publish Monitoring functional layer #829

Open
mjnagel opened this issue Sep 25, 2024 · 0 comments
Open

Create and publish Monitoring functional layer #829

mjnagel opened this issue Sep 25, 2024 · 0 comments
Assignees
Milestone

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Sep 25, 2024

Additional context in #736

As accepted in the ADR we should create and publish a "Monitoring" functional layer. This layer should include Grafana and Prometheus.

Definition of done for this layer:

  • New packages/monitoring folder with a zarf.yaml named core-monitoring importing grafana and prometheus (plus CRDs)
  • Readme identifying the contents of the layer as well as any dependency layers (base and identity-authorization in this case)
  • Validation task file, importing validations from components
  • CI filters modified to test "monitoring" on changes to appropriate files
  • CI workflows/tasks modified to add a "layer test" which builds and deploys the specified layer. This should be used on the CI filter in place of the existing single package test for the relevant package(s)
  • Publishing workflows/tasks updated to publish the layer, using monolithic versioning (versioned identical to core itself) - this will also require release-please config updates
  • Updating pepr/operator code to properly handle reconciliation when monitoring is not present (i.e. skip service/pod monitoring creation). Also ideally create warning events when a Package CR contains monitor configuration if this layer is not deployed (some initial draft changes were made to partially handle this with watches)

Existing draft PR may be helpful in the implementation here.

@mjnagel mjnagel added this to the 0.29.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants