-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove metrics-server from uds-core, add as a documented prerequisite #820
Comments
Discussed with some users - they have recently switched to EKS-d which does not provide metrics-server so having this as a standalone package or in core would be extremely beneficial to their deployments. I think for now we place to publish the functional layer of metrics-server to continue to enable this, but we could evaluate moving it out of core in the future. cc @jacobbmay |
5 tasks
mjnagel
added a commit
that referenced
this issue
Oct 7, 2024
## Description Adds the functional layer for metrics-server. ## Related Issue Related to #820 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
docandrew
pushed a commit
that referenced
this issue
Oct 17, 2024
## Description Adds the functional layer for metrics-server. ## Related Issue Related to #820 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today we include metrics-server as an optional component in UDS Core. Metrics-server is required to allow for autoscaling (HPA) as well as enabling the
kubectl top
commands. Historically Big Bang added metrics-server to provide it for distributions of k8s that did not provide it out of the box (Konvoy being the primary one at the time).In further evaluation of its usage, the inclusion of metrics-server has actually caused more pain than value. All known users of uds-core are on distros that provide metrics-server by default out of the box or as a standard addon:
Based on it being present in most distros already the benefits we are getting from deploying it with core are:
To reduce the confusion around this component it would be valuable to:
uds-package-metrics-server
to continue to provide this optional functionality, outside of coreThe text was updated successfully, but these errors were encountered: